Skip to content

[PWGLF] Add extra information in log in mcCentralityModule.h - #17798

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
romainschotter:mc-centrality
Sep 6, 2026
Merged

romainschotter merged 1 commit into
AliceO2Group:masterfrom
romainschotter:mc-centrality

Conversation

@romainschotter

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 24 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add extra information in log in mcCentralityModule.h [PWGLF] Add extra information in log in mcCentralityModule.h Sep 5, 2026
@romainschotter
romainschotter marked this pull request as ready for review September 5, 2026 22:50
@romainschotter
romainschotter enabled auto-merge (squash) September 5, 2026 22:50

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild

alibuild commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for fc9821e at 2026-09-06 01:24:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 4 errors and 11 warnings.'
Found 4 errors and 11 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/666efe92f23178580e631cb64a9cd2f0648aa194/O2Physics-code-check/errors.txt
PWGLF/Utils/mcCentralityModule.h:119:80: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGLF/Utils/mcCentralityModule.h:381:17: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
PWGLF/Utils/mcCentralityModule.h:451:28: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGLF/Utils/mcCentralityModule.h:524:28: error: narrowing conversion from 'Double_t' (aka 'double') to 'int' [bugprone-narrowing-conversions,-warnings-as-errors]
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/666efe92f23178580e631cb64a9cd2f0648aa194/O2Physics-code-check/warnings.txt
PWGLF/Utils/mcCentralityModule.h:56:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
PWGLF/Utils/mcCentralityModule.h:79:14: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Utils/mcCentralityModule.h:104:24: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Utils/mcCentralityModule.h:260:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Utils/mcCentralityModule.h:379:22: warning: use nullptr [modernize-use-nullptr]
PWGLF/Utils/mcCentralityModule.h:408:23: warning: use nullptr [modernize-use-nullptr]
PWGLF/Utils/mcCentralityModule.h:457:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Utils/mcCentralityModule.h:530:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Utils/mcCentralityModule.h:590:10: warning: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Utils/mcCentralityModule.h:600:87: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Utils/mcCentralityModule.h:675:30: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@romainschotter
romainschotter merged commit 704a8db into AliceO2Group:master Sep 6, 2026
13 of 15 checks passed
@romainschotter
romainschotter deleted the mc-centrality branch September 11, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants